Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement of a contract address on ListEvents #150

Closed
kroggen opened this issue Feb 4, 2022 · 1 comment
Closed

Remove requirement of a contract address on ListEvents #150

kroggen opened this issue Feb 4, 2022 · 1 comment
Labels

Comments

@kroggen
Copy link
Member

kroggen commented Feb 4, 2022

Currently the Aergo GRPC ListEvents and ListEventStream services require a contract address in the FilterInfo for they to work.

We are needing to list all events from a specific block and the above limitation is not allowing this.

When one contract is called, it can call other contracts and they can call others... and any of these contracts can emit events. An ARC1 token can be the last to be called, and we need to catch events from all the contracts.

Proposal

Remove the requirement of a contract address on ListEvents GRPC service, and list all events in the supplied block range

The same can be applied to the ListEventStream service, being able to listen to all events from the blockchain

Later

When doing this on the server side, we need also to update the clients:

  • aergocli
  • herajs
  • herapy
  • heraphp
  • libaergo
@kroggen
Copy link
Member Author

kroggen commented Feb 10, 2022

This is no longer a priority.

If someone finds it is a requirement, please reopen the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant