Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling timeout while preloading tx #294

Closed
hayarobi opened this issue Oct 17, 2023 · 2 comments
Closed

Improve handling timeout while preloading tx #294

hayarobi opened this issue Oct 17, 2023 · 2 comments

Comments

@hayarobi
Copy link
Member

In file contract/contract.go, there can be a bug while executing preloaded tx executor. Investigate and fix it if needed.

		// create a new context
		// FIXME need valid context
		ctx := NewVmContext(context.Background(), bs, nil, nil, receiver, contractState, txBody.GetAccount(), tx.GetHash(), request.bi, "", false, false, receiver.RP(), request.preloadService, txBody.GetAmountBigInt(), txBody.GetGasLimit(), txBody.Type == types.TxType_FEEDELEGATION)
@kroggen
Copy link
Member

kroggen commented Jan 30, 2024

If preloaded txns were removed, I suspect this issue can be closed

@kroggen
Copy link
Member

kroggen commented May 8, 2024

@hayarobi Can this be closed?

@kroggen kroggen closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants