This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
parse fields info into ModelDefinition #1730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Improves on #1729 |
|
|
machi1990
force-pushed
the
refactor/improve-selected-fields-logic
branch
2 times, most recently
from
e648cf1
to
c7e766e
Compare
|
Rebase needed. It will be best to try to land this changes into #936 |
machi1990
force-pushed
the
refactor/improve-selected-fields-logic
branch
3 times, most recently
from
f52ab40
to
124408b
Compare
machi1990
changed the title
|
@craicoverflow will you have some time to check this out? The idea will be to get this one merged and then add on some of the stuffs we discussed here #1023 to ignore fields that not in the database. |
|
Sure I will check this shortly. |
machi1990
force-pushed
the
refactor/improve-selected-fields-logic
branch
2 times, most recently
from
32a3bb3
to
4ee1407
Compare
machi1990
force-pushed
the
refactor/improve-selected-fields-logic
branch
from
4ee1407
to
d2595e3
Compare
|
Ah forgot about this completely. Let me rebase it so that we can get this in. |
Following aerogear#1675 (comment) and aerogear#1728 (comment) Also use this information to improve the selectedFields retrieval logic as suggested in aerogear#1729 (comment)
machi1990
force-pushed
the
refactor/improve-selected-fields-logic
branch
from
d2595e3
to
988869c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following
#1675 (comment)
and #1728 (comment)
Also use this information to improve the selectedFields retrieval logic as suggested in
#1729 (comment)