New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional basic auth for pushgateway #172

Merged

pb82 merged 1 commit into aerogear:master from hashworks:basicAuth

Aug 9, 2023

Contributor

hashworks commented Jul 21, 2023

Motivation

Resolves #145.

What

Allow users to provide username and password for basic auth protected pushgateways.

Why

Some pushgateways may require basic auth authentification.

How

https://github.com/prometheus/client_java/blob/main/integration_tests/it_pushgateway/src/main/java/io/prometheus/client/it/pushgateway/ExampleBatchJob.java#L32C13-L32C91

Verification Steps

A simple test has been added.

To test this completely:

Protect a pushgateway endpoint using basic auth
Set the required env variables
Start keycloak and verify metrics in pushgateway

Checklist:

Code has been tested locally by PR requester
Changes have been successfully verified by another team member


          Add optional basic auth for pushgateway

996f4e8

Resolves aerogear#145.

pb82 approved these changes

View reviewed changes

pb82 merged commit bc049a9 into aerogear:master

Contributor

pb82 commented Aug 9, 2023

thanks @hashworks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet