This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 277
💛 - Coveralls |
StephenCoady
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the knowledge to code review this but I have had a look anyway and nothing sticks out. I also verified that all endpoints work as expected.
sedroche
approved these changes
Aug 3, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The PR adds the MobileClient CRD and the basic structure for the endpoints to CRUDL mobile clients. As part of this, the operator-sdk is introduced to make it easier to interact with the CRD.
Why
In order to allow developers to manage the mobile clients, we need the endpoints on the backend and save the data somewhere. As described in the overview doc, we are using CRD to store the mobile client data.
Tasks
Verify
oc create -f ./deploy/crd.yaml
KUBERNETES_CONFIG
andNAMESPACE
env var, and start the servicecurl
to try the endpoints: