Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Changed VariantAdmin so that makes multipart post for iOS variants #15

Merged
merged 3 commits into from
Apr 1, 2020

Conversation

ziccardi
Copy link
Member

@ziccardi ziccardi commented Apr 1, 2020

Motivation

Fixes #13
Fixes #14

What

Changed the ApplicationAdmin class so that multipart post is done for ios variants

Why

The create variant for the ios type requires a multipart post (all other endpoints require a normal post of a json file)

…w version only the application name is required to create a new application

Fixes #14
@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Pull Request Test Coverage Report for Build 4a355e434d64948d85cdebd0e502e9119aecc2ae-PR-15

  • 4 of 13 (30.77%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-6.0%) to 67.46%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/variants/VariantsAdmin.ts 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
src/variants/VariantsAdmin.ts 1 56.1%
Totals Coverage Status
Change from base Build 826e4ca8afc9376c8d34f7460f036efbaa7f6a8a: -6.0%
Covered Lines: 48
Relevant Lines: 66

💛 - Coveralls

@ziccardi ziccardi merged commit d1ef5b7 into master Apr 1, 2020
@ziccardi ziccardi deleted the ISSUE_14 branch April 1, 2020 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admin.create doesn't work for iOS variants developer in PushApplication should be optional
1 participant