Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NUTS builder to use the new logprob interface #77

Closed
rlouf opened this issue Nov 16, 2022 · 0 comments · Fixed by #78
Closed

Refactor NUTS builder to use the new logprob interface #77

rlouf opened this issue Nov 16, 2022 · 0 comments · Fixed by #78
Labels
important refactoring A change that improves the codebase but doesn't necessarily introduce a new feature

Comments

@rlouf
Copy link
Member

rlouf commented Nov 16, 2022

The changes introduced in aesara-devs/aeppl#196 will be merged in AePPL. It should actually simplify the code in nuts.py: rvs_to_sample is now enough to do most things, and variables not sampled by NUTS are introduced in the logprob graph using the realized keyword.
@rlouf rlouf added refactoring A change that improves the codebase but doesn't necessarily introduce a new feature important labels Nov 16, 2022
@rlouf rlouf changed the title Refactor NUTS builder with new logprob interface Refactor NUTS builder to use the new logprob interface Nov 16, 2022
@rlouf rlouf mentioned this issue Nov 18, 2022
Merged
@rlouf rlouf closed this as completed in #78 Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
important refactoring A change that improves the codebase but doesn't necessarily introduce a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update NUTS to work with AePPL's new joint_logprob interface rlouf/aemcmc
1 participant
@rlouf