Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip creating a store on integration tests #857

Merged
merged 1 commit into from
Aug 23, 2022
Merged

test: skip creating a store on integration tests #857

merged 1 commit into from
Aug 23, 2022

Conversation

sborrazas
Copy link
Contributor

No description provided.

@sborrazas sborrazas self-assigned this Aug 22, 2022
thepiwo
thepiwo approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@thepiwo thepiwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have the numbers changed?

@sborrazas
Copy link
Contributor Author

These two PRs #826 and #819 fix the fact that before them these numbers were calculated the wrong way once the server was restarted. It then propagated these wrong calculations in the future generations and made these numbers non-deterministic.

jyeshe
jyeshe approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@sborrazas sborrazas merged commit 654228e into master Aug 23, 2022
@sborrazas sborrazas deleted the integration-store branch August 23, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyeshe jyeshe jyeshe approved these changes

@thepiwo thepiwo thepiwo approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sborrazas @thepiwo @jyeshe