docs: update readme for nft related endpoints #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
force-pushed
the
nft-readme-docs
branch
from
01bcb82
to
9ae447d
Compare
jyeshe
force-pushed
the
nft-readme-docs
branch
from
9ae447d
to
b4cd825
Compare
thepiwo
approved these changes
Sep 13, 2022
README.md
Outdated
| @@ -3147,6 +3147,299 @@ $ curl -s "https://mainnet.aeternity.io/mdw/v2/transfers?account=ak_7myFYvagcqh8 | |||
|
|
|||
| --- | |||
|
|
|||
| ## NFTs (AEX-141 contracts and tokens) | |||
There was a problem hiding this comment.
will you also add a reference in the directory?
There was a problem hiding this comment.
@thepiwo So far the NFT images are not downloaded or are you imagining other directory use?
There was a problem hiding this comment.
I mean in the headlines of the readme to add a reference to this section
sborrazas
reviewed
Sep 13, 2022
README.md
Outdated
| Returns creation and stats information in default paginated way for all NFT collection. The same general paginated parameters might be used: | ||
|
|
||
| - `direction` with `forward` value ascendinly sorts the response contracts by creation transaction index while `backward` works for desc sorting | ||
| - `limit` defines the page size |
There was a problem hiding this comment.
Perhaps we can just say that these are paginated endpoint to avoid repeating that there's limit and direction which applies for all paginated endpoints?
sborrazas
approved these changes
Sep 13, 2022
jyeshe
force-pushed
the
nft-readme-docs
branch
from
3433ae2
to
df38bd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #629
Depends on #899