-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-react-app@5 compatibility #122
Conversation
@@ -12726,7 +12722,8 @@ | |||
"util-deprecate": { | |||
"version": "1.0.2", | |||
"resolved": "https://registry.npmjs.org/util-deprecate/-/util-deprecate-1.0.2.tgz", | |||
"integrity": "sha1-RQ1Nyfpw3nMnYvvS1KKJgUGaDM8=" | |||
"integrity": "sha1-RQ1Nyfpw3nMnYvvS1KKJgUGaDM8=", | |||
"dev": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is dev: true in the lock file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand the util-deprecate
was used by bs58check
(not a dev dependency), and since it was removed, then I assume there is some other package that still depends on util-deprecate
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found it in the docs :)
2c41b6a
to
a623a44
Compare
@davidyuk is this ready? can we merge? we need a new release for calldata-lib then, right? |
I just found that |
4f23793
to
a2afc15
Compare
package.json
Outdated
@@ -29,9 +29,10 @@ | |||
"./tests/test.js": "./tests/browser/test.js" | |||
}, | |||
"dependencies": { | |||
"blakejs": "^1.1.1", | |||
"bs58check": "^2.1.2", | |||
"blakejs": "github:aeternity/blakejs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a fixed release version here, also a semver compliance of this lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on tuesday the 15.03. we will either take the updated version of the lib or release and publish our own fork on npm, see dcposch/blakejs#19 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dincho just in case the contributor there could create a specific tag for the library on github - would it be ok to rely on that or do we want to have it published on NPM? see discussion here: dcposch/blakejs#20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPM releases have one very strong property: https://docs.npmjs.com/policies/unpublish
So yes, I insist on NPM release dependancy.
closes #123
"Can't resolve 'stream'" is because of
bs58check
package (depends oncreate-hash
=>cipher-base
=> requiresstream
)