Add no code to aci, make /aci to output in canonical format #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidyuk
force-pushed
the
add-no-code-to-aci
branch
2 times, most recently
from
7865104
to
aa3d553
Compare
davidyuk
force-pushed
the
add-no-code-to-aci
branch
from
aa3d553
to
f9fc634
Compare
hanssv
approved these changes
Jun 26, 2023
| generate_aci(Contract, Options) -> | ||
| Opts = compile_options(Options), | ||
| try aeso_aci:contract_interface(json, Contract, Opts) of | ||
| try aeso_aci:contract_interface(json, Contract, Opts ++ [{no_code, true}]) of |
There was a problem hiding this comment.
In aesophia_cli we explicitly require a --no-code option to enable this, but I guess this is fine (you could possibly get an ACI for non-compileable code, but that wouldn't be a big problem I think).
|
any blockers for merging that? |
radrow
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to aeternity/aesophia_cli#79
Required in aeternity/aepp-sdk-js#1845
This PR is supported by the Æternity Crypto Foundation