Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin parent chain hyperchain connector #4124

Merged
merged 14 commits into from
May 26, 2023
Merged

Bitcoin parent chain hyperchain connector #4124

merged 14 commits into from
May 26, 2023

Conversation

seanhinde
Copy link
Contributor

@seanhinde seanhinde commented Apr 10, 2023 •
edited
Loading

Basic functionality for bitcoin parent chain connector

TODO:

  • Configuration params
  • Put child chain network id in commitment (only 15 bytes remain in BTC OP_RETURN)?
  • Testing in a system with a full bitcoin node

Pushed to future PR

  • Filtering to specific account UTXOs
  • Consider having a pool of client accounts to avoid re-using UTXOs with low confirmation counts (definitely not 0)
  • Allow different host/port for offline bitcoind based wallet node

This PR was sponsored by the ACF

@seanhinde seanhinde changed the title Bitcoin parent chain hyperchain connector [WIP] Bitcoin parent chain hyperchain connector May 26, 2023
@seanhinde seanhinde requested review from velzevur, hanssv and uwiger and removed request for velzevur and hanssv May 26, 2023 13:02
hanssv
hanssv approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@hanssv hanssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see that this would affect the normal node operations, only glanced through the actual bitcoin/dogecoin stuff 👍

uwiger
uwiger approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@uwiger uwiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanhinde seanhinde merged commit ce4c347 into master May 26, 2023
@dincho dincho added the kind/feature Issues or PRs related to a new feature label Jun 28, 2023
mitchelli pushed a commit that referenced this pull request Jan 22, 2024
@seanhinde @mitchelli
Bitcoin parent chain hyperchain connector (#4124)
6ec2bfd 
* Bitcoin parent chain hyperchain connector

* Made Fee and Amount configurable for commitment Tx

* Added Dogecoin parent support

* Abstract encoding of commitment to one place

* Switch to secure and anonymous Commitment format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwiger uwiger uwiger approved these changes

@hanssv hanssv hanssv approved these changes

@velzevur velzevur Awaiting requested review from velzevur

Assignees
No one assigned
Labels
kind/feature Issues or PRs related to a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanhinde @hanssv @uwiger @dincho