DeepLinks #112
Merged
DeepLinks #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-112-dex-ui.stg.aepps.com |
AtanasKrondev
force-pushed
the
feature/deeplinks
branch
2 times, most recently
from
70287d4
to
e834f56
Compare
AtanasKrondev
force-pushed
the
feature/deeplinks
branch
2 times, most recently
from
0d0bcae
to
4bd57a8
Compare
CedrikNikita
requested changes
Jan 18, 2022
There was a problem hiding this comment.
First of all, this should be properly rebased to avoid last commit.
There is no need to create a whole entity "universal". We just need to initialize initRouter, initFactory, initWae after sdk was initialized.
I don't like the way we just copy paste all of the methods in the aeternity module to use deeplinks. Even with this approach Pr doesn't fulfill all the functionality that aeternity module have.
And it doesn't work.
CedrikNikita
force-pushed
the
feature/deeplinks
branch
2 times, most recently
from
df9c1ae
to
1fbd5cc
Compare
CedrikNikita
force-pushed
the
feature/deeplinks
branch
from
1fbd5cc
to
dc212bf
Compare
kenodressel
approved these changes
Jan 28, 2022
CedrikNikita
force-pushed
the
feature/deeplinks
branch
from
dc212bf
to
549342d
Compare
CedrikNikita
approved these changes
Feb 1, 2022
This was referenced Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@CedrikNikita:
fixes #61
refactoring within this PR is part of #113