Implemented AttributeChain attribute. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added attribute chain variant of attribute. - Added processing of AttributeChain in surface. - Started implementation of linking for AttributeChain.
This commit contains my first attempt at adding the `AttributeChain` into the linking chain. This means that we should now be able to link into the MCRT. I have also cleaned up after my first exploration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
AttributeChainvariant to theAttributeenums, as well as implementing it into the linker chain. This means that we can now chain together multiple attributes onto a single surface tag.I've also added a unit test to check the deserialisation of JSON into the
AttributeChainvariant too.