Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour moles for distinctiveness in set, not uuid, in 'mel rotomap-{edit,view}' #6

Closed
aevri opened this issue Oct 16, 2016 · 0 comments

Comments

@aevri
Copy link
Owner

aevri commented Oct 16, 2016

Colours are currently picked based on the uuid of moles. There are inevitably co-incidences where the colours picked are the same or similar.

It doesn't seem to be so useful for moles to have a consistently chosen colour between runs of commands - they are not particularly memorable.

If we're free to choose arbitrary colours then perhaps instead we can choose colours based on the limited number of moles available from the arguments passed to rotomap-view and rotomap-edit.

Perhaps we can use a different colouring schemes depending on the number of moles to colour, taking advantage of more distinct palettes when the number is low.

aevri added a commit that referenced this issue Oct 16, 2016
Colours were previously picked based on the uuid of moles. There are
inevitably co-incidences where the colours picked are the same or
similar.

It doesn't seem to be so useful for moles to have a consistently chosen
colour between runs of commands - they are not particularly memorable.

If we're free to choose arbitrary colours then instead we can choose
colours based on the limited number of moles available from the
arguments passed to rotomap-view and rotomap-edit.

Use the mel.rotomap.tricolour colouring scheme. So depending on the
number of moles to colour, moles can be coloured more distinctively.

Fixes #6.

Test Plan:
$ ./meta/run_tests.sh
.. Run mel rotomap-edit and observe that colours are better ..
@aevri aevri closed this as completed in 88b2c6b Oct 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant