Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8 modifications #116

Merged
merged 6 commits into from
Feb 17, 2020
Merged

PEP8 modifications #116

merged 6 commits into from
Feb 17, 2020

Conversation

fmeynadier
Copy link
Contributor

Fix #115

Good idea to tidy up the code style, I think it makes it more readable to everyone...

I run a pep8 check each time I save the files (vim + syntastic + flake8 + pyflakes)... So it was easy and fast for me !

Note that on lines 1371 and 1377 I left the np.isnan() == False form as == is not to be replaced by is in this context, as hinted by the pep8 checker. the "noqa" comment tells the checker to keep silent, I don't know if it is taken into account by pycodestyle.

@coveralls
Copy link

coveralls commented Feb 17, 2020

Coverage Status

Coverage increased (+2.4%) to 83.705% when pulling 959beeb on fmeynadier:master into 7caee86 on aewallin:master.

@fmeynadier
Copy link
Contributor Author

So:

I finally managed to setup travisCI + coveralls on my own github repos, so now I see if the tests fail or not...

This means I managed to fiddle with the .travis.yml file and make the windows test suite run (fix #114). By the way I moved the coverage from python 2.7 to 3.4, as it seems more relevant now. Perhaps we should consider dropping tests for 2.7 altogether, as it has now officialy reached EOL.
Even 3.4 is EOL since march 2019, probably we should switch at least to 3.5 for the linux version

As a result of the PEP8 reformating, coveralls was under the impression that coverage had decreased, and failed : I tried to enhance a little bit the coverage to compensate for that. Mostly, I have included the "mtie_phase_fast" function in the test suite, but it does not seem to work well so I put the test as "xfail". The comment says it is "not finished" : maybe we should raise a warning whenever someone tries to use it until it gives good results (I expect the results to be nearly the same as mtie, right ?).

@aewallin
Copy link
Owner

thanks, that's a lot of work!
I agree that the old python versions can be dropped at some point. Maybe the next Ubuntu LTS in 2020.04 will have python 3 by default?

@aewallin aewallin merged commit d91f2c4 into aewallin:master Feb 17, 2020
fmeynadier added a commit to fmeynadier/allantools that referenced this pull request Feb 18, 2020
Type of exception deduced from aewallin#82
aewallin added a commit that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pycodestyle issues as of 2020-02
3 participants