Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust hiding of require() calls for react-native #38

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

barbogast
Copy link
Contributor

The previous code worked when the app was build in for debugging but failed
when it was build for release. This makes sure the react-native packager
ignores the require calls in both cases.

The previous code worked when the app was build in for debugging but failed
when it was build for release. This makes sure the react-native packager
ignores the require calls in both cases.
@barbogast
Copy link
Contributor Author

Fixes #31

Copy link
Collaborator

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In prod builds it was probably constant folded, which is why it broke.

@af af merged commit 3a5ce26 into af:master Jun 17, 2017
@af
Copy link
Owner

af commented Jun 17, 2017

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants