-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing underscore in mailbox returns empty error #41
Comments
Try unreleased master branch for your temp fix... TRY #14 Fix... untested for now Hi, I'm away and can't run the test on my current environment. Good luck! It's just a REGEX change, so you can look at this commit and try alternatives. |
I apologize, but what I did on my travels never seemed to make it to the server. I'm home now, jet lagged, and just tested and pushed a fix for this. You can try to use this from your Gemfile pointing to the head of the master branch instead of the gem name. I'll try to release this once I do more tests. |
@yanismydj Does this fix your original issue? |
I had a user reporting that they could not reset their password in Devise. Their email has a mailbox with a trailing underscore (
exampleemail_@gmail.com
), but theemail_address
gem is returning.valid?
asfalse
, and.error
as empty string. This is different from #35 as the issue is not that we are incorrectly marking the email as invalid, but rather that we are simply returning a nil/empty error message which makes it difficult to give feedback to the user.The text was updated successfully, but these errors were encountered: