Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate to BFF #340

Merged
merged 10 commits into from
Nov 8, 2023
Merged

feat: migrate to BFF #340

merged 10 commits into from
Nov 8, 2023

Conversation

carlos-affinidi
Copy link
Collaborator

@carlos-affinidi carlos-affinidi commented Oct 24, 2023 •
edited
Loading

Updated CLI to use BFF:

  • Created a BFFService to call BFF custom endpoints
  • Updated the authentication flow to use BFF. Instead of receiving sessionId as cookie we now request it from BFF using the state to be able to use TLS.
  • Restructured configuration files. Now we only have a single file called credentials-v2.json with the sessionId
  • Updated IAM and VPA service clients to point to BFF and inject the SessionID as Cookie header
  • Updated commands to no longer have to specify the token to use when calling services
  • Changed Project commands to use BFF custom endpoints instead of IAM
  • Changed whoami command to use BFF endpoint instead of the no longer stored access token
  • Merged success and error auth result pages into a single one
  • Improved how we handle environments and configuration so it is easier to point to different envs of BFF
  • Removed --project-id flag from affinidi start as it is currently not supported by bff
  • Removed check-version hook as the conf files have been restructured
  • Removed unused packages
  • Removed integration tests
  • Updated unit tests

@socket-security
Copy link

socket-security bot commented Oct 24, 2023 •
edited
Loading

Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
zod 3.22.2...3.22.4 None +0/-0 628 kB colinmcd94

🚮 Removed packages: @types/jsonwebtoken@9.0.3, @types/simple-oauth2@5.0.4, jsonwebtoken@9.0.2, license-checker@25.0.1, qs@6.11.2, simple-oauth2@5.0.0

@carlos-affinidi carlos-affinidi changed the title feat: get cookie from BFF feat: migrate to BFF Nov 6, 2023
@carlos-affinidi carlos-affinidi marked this pull request as ready for review November 6, 2023 23:11
pulkitb2
pulkitb2 previously approved these changes Nov 7, 2023
View reviewed changes
rbrazhnyk
rbrazhnyk previously approved these changes Nov 7, 2023
View reviewed changes
@carlos-affinidi carlos-affinidi merged commit 9c38233 into beta Nov 8, 2023
9 checks passed
@carlos-affinidi carlos-affinidi deleted the bff-auth branch November 8, 2023 08:24
carlos-affinidi pushed a commit that referenced this pull request Nov 8, 2023
@semantic-release-bot
chore(release): 2.0.0-beta.10 [skip ci]
ab62cc0 
# [2.0.0-beta.10](v2.0.0-beta.9...v2.0.0-beta.10) (2023-11-08)

### Features

* (FTL-12541) add implementation to automate the framework, library and redirect uris fetch ([#343](#343)) ([8ae75fb](8ae75fb))
* migrate to BFF ([#340](#340)) ([9c38233](9c38233))
@carlos-affinidi
Copy link
Collaborator Author

🎉 This PR is included in version 2.0.0-beta.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrazhnyk rbrazhnyk rbrazhnyk approved these changes

@pulkitb2 pulkitb2 pulkitb2 left review comments

Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlos-affinidi @rbrazhnyk @pulkitb2