This repository has been archived by the owner on Aug 29, 2024. It is now read-only.
feat(FTL-7654): added update to SDK to support the Truecaller flow
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksiipiliugin
changed the title
Truecaller flowTruecaller flow
…ile. fixed profile flow
oleksiipiliugin
requested review from
cosminm-affnd,
linn-affinidi,
Volland and
yaroslava-kurash
yaroslava-kurash
previously approved these changes
Nov 28, 2022
| require('./services') | ||
| require('./AffinityWallet.test') | ||
| require('./NetworkMember.test') | ||
| // require('./services') |
Volland
reviewed
Nov 28, 2022
| @@ -643,3 +658,79 @@ parallel('CommonNetworkMember [OTP]', () => { | |||
| }) | |||
| }) | |||
| }) | |||
|
|
|||
| // describe('CommonNetworkMember [TrueCaller]', () => { | |||
There was a problem hiding this comment.
@oleksiipiliugin why we comment it out ?
There was a problem hiding this comment.
ah we probably need to deploy awb first
Volland
approved these changes
Nov 28, 2022
yaroslava-kurash
approved these changes
Nov 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the signin flow with the Truecaller profile/token.
Logic is the same as for sigin passwordless with phone number, but without sending OTP to the user.
With this new feature, we are able to create a new user in the Cognito pool or login if it exists.
The main changes are in
sdk/coreandlib/user-management. Also, support for new endpoints was added for the internal key storage service.