-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to create a AfidSet class #14
Merged
Merged
Commits on Aug 22, 2023
-
refactor to create a class for afids
An `afids.py` file has been added in order to create an AFIDSet dict class, enabling the storing of both metadata information, well as loading fiducials from files directly into a dataframe. The choice of using a dataframe here is for easier downstream manipulation. - `get_afid` has been moved into here as a method of the AfidSet class Moved extension specific file handling into its own `.py` files (e.g. `extensions/fcsv.py`). This choice was made to simplify the maintenance of handling different file extensions. - Separate semi-private methods are used for grabbing the metadata, as well as loading the fiducials into a polars dataframe. Additionally `io.py` has been refactored to generalize the handling of different file types (calling the methods within the different `extensions`). Updates poetry.lock and pyproject.toml to include the `attrs` library
Configuration menu - View commit details
-
Copy full SHA for 6defa80 - Browse repository at this point
Copy the full SHA 6defa80View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddaea1b - Browse repository at this point
Copy the full SHA ddaea1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c7dfee - Browse repository at this point
Copy the full SHA 8c7dfeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 485314e - Browse repository at this point
Copy the full SHA 485314eView commit details -
Configuration menu - View commit details
-
Copy full SHA for af9a15a - Browse repository at this point
Copy the full SHA af9a15aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f8c2299 - Browse repository at this point
Copy the full SHA f8c2299View commit details -
Configuration menu - View commit details
-
Copy full SHA for df85426 - Browse repository at this point
Copy the full SHA df85426View commit details
Commits on Aug 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bef365d - Browse repository at this point
Copy the full SHA bef365dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29cdcef - Browse repository at this point
Copy the full SHA 29cdcefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cb62be - Browse repository at this point
Copy the full SHA 7cb62beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c51097 - Browse repository at this point
Copy the full SHA 8c51097View commit details -
- Remove `io.py`, moving methods to the AfidSet class. `load` is now a ClassMethod while `save` is a method of the instance. - Added an `AfidPosition` class, which is now used to store AFIDs - Drops polars from use, favouring `List[AfidPosition]` instead - Update mismatched desc in template.fcsv - Update strategies.py to generate coords using `AfidPosition` - Update all tests to correspond with changes made
Configuration menu - View commit details
-
Copy full SHA for 488abd5 - Browse repository at this point
Copy the full SHA 488abd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6001c00 - Browse repository at this point
Copy the full SHA 6001c00View commit details -
Configuration menu - View commit details
-
Copy full SHA for c3fa441 - Browse repository at this point
Copy the full SHA c3fa441View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5e83cd - Browse repository at this point
Copy the full SHA e5e83cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fa2177 - Browse repository at this point
Copy the full SHA 6fa2177View commit details -
Configuration menu - View commit details
-
Copy full SHA for edd92be - Browse repository at this point
Copy the full SHA edd92beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e13eebd - Browse repository at this point
Copy the full SHA e13eebdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.