phase vs. fringeshift

[iltommi]

what is labeled "phase" in the wavelet analysis is rather "fmod(fringeshift,1)". I propose to rename phase with fringeshift in the GUI and nPhysImage

[aflux]

It's true that calling it phase without any further explanation it's
definitely misleading.

However I don't find "fringeshift" so much self-explanatory, since you
don't specify the unit...

Shouldn't we just write very big "phase/2pi" ?

On 03/11/2014 02:50 PM, iltommi wrote:

what is labeled "phase" in the wavelet analysis is rather
"fmod(fringeshift,1)". I propose to rename phase with fringeshift in the
GUI and nPhysImage

—
Reply to this email directly or view it on GitHub
#21.

[iltommi]

ok I'll do it

On Tue Mar 11 17:17:05 2014, aflux wrote:

It's true that calling it phase without any further explanation it's
definitely misleading.

However I don't find "fringeshift" so much self-explanatory, since you
don't specify the unit...

Shouldn't we just write very big "phase/2pi" ?

On 03/11/2014 02:50 PM, iltommi wrote:

what is labeled "phase" in the wavelet analysis is rather
"fmod(fringeshift,1)". I propose to rename phase with fringeshift in the
GUI and nPhysImage

—
Reply to this email directly or view it on GitHub
#21.

—
Reply to this email directly or view it on GitHub
#21 (comment).