Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions to fix after the React upgrade #662

Closed
vincentfretin opened this issue Dec 9, 2022 · 3 comments · Fixed by #664
Closed

Regressions to fix after the React upgrade #662

vincentfretin opened this issue Dec 9, 2022 · 3 comments · Fixed by #664

Comments

@vincentfretin
Copy link
Contributor

Some regressions with the upgrade #647 that was listed in the description as remaining todos:

  • copy html to clipboard broken
  • opening the textures modal doesn't work
@vincentfretin vincentfretin mentioned this issue Dec 9, 2022
Merged
2 tasks
@dmarcos
Copy link
Member

dmarcos commented Dec 23, 2022

Do you think we can get this in for A-Frame 1.4.0? Thanks so much for all the inspector improvements

@vincentfretin
Copy link
Contributor Author

I'm looking into it right now.

@vincentfretin vincentfretin mentioned this issue Dec 24, 2022
Merged
@vincentfretin
Copy link
Contributor Author

Ok I fixed the two issues in #664

dmarcos pushed a commit that referenced this issue Dec 24, 2022
@vincentfretin
Fix regressions introduced by the latest merged changes (#664) (fix #662
e8798c7 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regressions introduced by the latest merged changes vincentfretin/aframe-inspector
2 participants
@dmarcos @vincentfretin