Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hololens fails to exitVR successfully #3881

Open
rc1 opened this issue Nov 27, 2018 · 6 comments
Open

Hololens fails to exitVR successfully #3881

rc1 opened this issue Nov 27, 2018 · 6 comments

Comments

@rc1
Copy link

rc1 commented Nov 27, 2018

Description:

Given I am using a Hololens in immersive mode,
When I leave the immersive mode,
Then the aframe stops rendering (the browser window only display a white background and not the scene).

The reason the rendering is stops is due to an error being thrown within a component's tick. I haven't been able to track down the component. This happens with a blank scene.

The error is as follows;

TypeError: Unable to get property 'pressed' of undefined or null reference at tick (eval code:65:5) at tick.value (https://server/aframe/aframe-master.js:73647:11) at render.value (https:/server/aframe/aframe-master.js:73695:31) at bound (https:/server/aframe/aframe-master.js:77038:7) at animationLoop (https://server/aframe/aframe-master.js:27442:4)

As an aside, it would be great if component and system ticks were wrapped within a try catch. The catch could log the error via console.error and provide information of which component was being rendered rather than throwing and stopping the rendering.

  • A-Frame Version: 0.8.2
  • Platform / Device: Hololens
  • Reproducible Code Snippet or URL: Any example
@rc1 rc1 mentioned this issue Nov 27, 2018
@wmurphyrd
Copy link
Collaborator

The pressed property name is used in tracked controls for gamepad button state. Does you still experience the issue if you don't enable your hololens gesture code?

@rc1
Copy link
Author

rc1 commented Dec 15, 2018 via email

@dmarcos
Copy link
Member

dmarcos commented Jan 26, 2019

@wmurphyrd Any recommendation on what we should do here?

@wmurphyrd
Copy link
Collaborator

@dmarcos starting work on a controller component for the hololens gesture. The odd thing hololens does that is probably causing the problem is it creates gamepad entries when detecting a gesture and then deletes the gamepad when the gesture ends. I'll find a way to work around it and include in the controller PR

@3DataWill
Copy link
Contributor

@dmarcos are individual controller components going to be obsolete with WebXR/A-Frame 0.9?

@dmarcos
Copy link
Member

dmarcos commented Feb 1, 2019

@3DataWill No. WebXR is still evolving and will include a mechanism to identify individual controllers. immersive-web/webxr#479

Thanks for helping with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants