Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utils device isIOS and isMobile checks fail on iPad Pro 12.9 Safari #5494

Closed
IntraNoctem opened this issue Mar 8, 2024 · 5 comments
Closed

Comments

@IntraNoctem
Copy link

IntraNoctem commented Mar 8, 2024

Description:

The utils device checks isIOS and isMobile fail on iPad Pro 12.9 when using Safari browser. In Chrome they succeed.

iOS-isMobile

userAgent strings:

  • 14.0: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1 Safari/605.1.15"

  • 16.1: "Mozilla/5.0 (iPad; CPU OS 16_0 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) CriOS/92.0.4515.90 Mobile/15E148 Safari/604.1"

  • 17.1: "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/17.1 Safari/605.1.15"

  • A-Frame Version: 1.5.0

  • Platform / Device:

    • iPad Pro 12.9 2021 (OS 14.0 and 17.1)
    • iPad Pro 12.9 2022 (iOS 16.1)
@dmarcos
Copy link
Member

dmarcos commented Mar 9, 2024

Just curious. What you are trying to accomplish?

@IntraNoctem
Copy link
Author

There are some use cases in which it is necessary to know whether it is a mobile device, e.g. a help dialogue that describes either touch or mouse/keyboard gestures.

@dmarcos
Copy link
Member

dmarcos commented Mar 11, 2024

Feel free to open an PR to fix it.

@arpu
Copy link
Contributor

arpu commented Mar 11, 2024

some infos i found to this problem is https://github.com/pmndrs/detect-gpu/blob/master/src/internal/deviceInfo.ts#L15

@dmarcos
Copy link
Member

dmarcos commented Mar 19, 2024

I'll take a PR if someone wants to fix it. Don't have access to the device to test. Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants