Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add events to know when VR mode has been entered #759

Closed
ngokevin opened this issue Jan 13, 2016 · 1 comment
Closed

Add events to know when VR mode has been entered #759

ngokevin opened this issue Jan 13, 2016 · 1 comment

Comments

@ngokevin
Copy link
Member

Issue by cvan
Thursday Dec 17, 2015 at 21:27 GMT
Originally opened as https://github.com/aframevr/aframe-core/issues/698

It's useful to know when VR mode has been entered. With the current API that piggybacks off of requestFullscreen, you can listen for the fullscreenchange event, but it's kind of a hack because you don't know necessarily if it's a vrDisplay.

Related: see #286 and #286 (comment)

and also match-media proposal here: https://github.com/aframevr/aframe-core/pull/518/files#diff-68b5544f3cdb6b74d38ac2e61a2e2f74R37
@cvan cvan added the important label Jan 14, 2016
dmarcos added a commit that referenced this issue Feb 1, 2016
@dmarcos
Merge pull request #776 from ngokevin/scenecomponents
14e5503 
move scene logic to components (fixes #239, #759, #886)
@ngokevin
Copy link
Member Author

ngokevin commented Feb 1, 2016

#776

enter-vr and exit-vr as well as states on the scene.

@ngokevin ngokevin closed this as completed Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cvan @ngokevin