support inline (and autoplay) videos on iOS when added to Homescreen #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,6 +150,22 @@ var AScene = module.exports = registerElement('a-scene', { | |||
| } | |||
| }, | |||
|
|
|||
| promptForIOS: { | |||
There was a problem hiding this comment.
I'm going to move this logic to its own third-party component because I want to add an "Add to Homescreen" toast message. and, it's way too hairy to add all that logic to A-Frame core IMO.
|
this change enables inline videos to be played and automatically (when |
| if (!videoEl.hasAttribute('crossorigin')) { | ||
| videoEl.crossOrigin = true; | ||
| } | ||
| if (!videoEl.hasAttribute('webkit-playsinline')) { |
There was a problem hiding this comment.
Do we need to check if the attribute is already there? Can we just set it?
This was referenced Apr 13, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.