fix registerPrimitive property merging (fixes #1324) #1332
Conversation
|
|
||
| self.setAttribute(componentName, propName, componentData[propName]); | ||
| }); | ||
| return; |
There was a problem hiding this comment.
perhaps we should return only if self.setAttribute(…) actually got called?
There was a problem hiding this comment.
I'm only returning here to mimic an if/else. Not a big fan of that style since it's less clear on the intent, but dmarcos likes that.
| applyDefaultComponents: { | ||
| value: function () { | ||
| var self = this; | ||
| var defaultData = utils.extendDeep(this.defaultAttributes); |
There was a problem hiding this comment.
Is it really necessary to create a local copy of the object?
There was a problem hiding this comment.
yeah. if you modify this object, it will affect all other entities created from this prototype.
There was a problem hiding this comment.
I don't see where is the defaultData object modified.
There was a problem hiding this comment.
OK, I think since I removed keeping track of component data, this is no longer needed. Good catch.
Description: Mapped attributes were overwriting defined components.
Changes proposed:
setAttribute(component, propName, propValue)syntax.