Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'defaultAttributes' to 'defaultComponents' in Primitive Definitions #1460

Merged
merged 2 commits into from
May 12, 2016

Conversation

msimpson
Copy link
Contributor

@msimpson msimpson commented May 12, 2016

This needs review as I had to alter the prototype to use defaultComponentsFromPrimitive in registerPrimitive instead of simply defaultComponents since Object.create will override the defaultComponents from the a-entity prototype. This, if allowed, would cause test failures as getAttribute subsequently returns null for those overridden attributes (i.e. position, scale, etc.).

Fixes #1330.

@dmarcos
Copy link
Member

dmarcos commented May 12, 2016

It looks good to me. I let @ngokevin merge it.

@ngokevin ngokevin merged commit 91a8504 into aframevr:master May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants