Change 'defaultAttributes' to 'defaultComponents' in Primitive Definitions #1460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs review as I had to alter the prototype to use
defaultComponentsFromPrimitive
inregisterPrimitive
instead of simplydefaultComponents
since Object.create will override thedefaultComponents
from thea-entity
prototype. This, if allowed, would cause test failures asgetAttribute
subsequently returnsnull
for those overridden attributes (i.e. position, scale, etc.).Fixes #1330.