Added default primitive to geometry #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small test for geometry component just to check an empty primitive doesn't throw error? |
|
Test added. |
| @@ -16,6 +16,11 @@ suite('geometry', function () { | |||
| }); | |||
|
|
|||
| suite('update', function () { | |||
| test('empty geometry', function () { | |||
There was a problem hiding this comment.
coudl do allows empty geometry to be more specific
There was a problem hiding this comment.
not a big deal though, can merge anyways
|
Thanks, I was waiting for the tests to pass, then eventually forgot about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When you try to add an empty entity with an empty geometry Aframe throws an error as it looks for a
primitivevalue to return the expected geometryBuffer.We should add a default value so empty component doesn't give you any error and also give you some kind of basic behaviour (the same as if you put an empty material).
So basically what I've done is add a
default: 'box'to the primitive schema and you'll get a box by default.Fixes #1514