don't require shader to return materials, only set #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.shader.el = this.el; | ||
| material = this.shader.init(data); | ||
| this.setMaterial(material); | ||
| var ShaderClass = shaders[shaderName] && shaders[shaderName].Shader; |
There was a problem hiding this comment.
I think the world class here is not a good fit. It's confusing. We don't use classes. The capitalization of the variable already indicates a constructor. It's probably the most widely spread convention in JS.
There was a problem hiding this comment.
Is there another word we can use? Because there's shaders, .Shader, this.shader, shader.
There was a problem hiding this comment.
I think the capitalization is enough to discriminate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches geometry registration. And the extra return is not needed since it's set on the instance, and it's weird for init/update methods to be returning.