Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on component names that contain uppercase characters #2233

Merged
merged 3 commits into from
Jan 3, 2017
Merged

Warn on component names that contain uppercase characters #2233

merged 3 commits into from
Jan 3, 2017

Conversation

imgntn
Copy link
Contributor

@imgntn imgntn commented Jan 3, 2017

Description:

This PR checks for uppercase characters in component names. Since HTML changes these to lowercase, it's important that users have a warning about how to correctly access their components.

#2139

Changes proposed:

  • Use a regex to test the name for uppercase, warn if this is the case.

@imgntn imgntn changed the title Warn on components names that contain uppercase characters Warn on component names that contain uppercase characters Jan 3, 2017
@dmarcos
Copy link
Member

dmarcos commented Jan 3, 2017

Thanks a lot!

@dmarcos dmarcos merged commit e8b2e47 into aframevr:master Jan 3, 2017
ngokevin pushed a commit to pulilab/aframe that referenced this pull request Feb 6, 2017
@imgntn @ngokevin
Warn on component names that contain uppercase characters (aframevr#2233
e1c1198 
)

* warn on component names containing uppercase

* use standard style for linting

* pass linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imgntn @dmarcos