-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept el.setAttribute('mixin', '') #2291
Conversation
Thanks! |
var el = this.el; | ||
mixinFactory('material', {material: 'shader: flat'}); | ||
mixinFactory('position', {position: '1 2 3'}); | ||
el.setAttribute('mixin', 'material position'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we check for el.mixinEls
too? assert.equal(el.mixinEls.length, 2)
before and assert.equal(el.mixinEls.length, 0)
after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea. I will.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
BTW, I'm thinking to replace
What do you guys think? |
sure! |
Description:
This PR enables
el.setAttribute('mixin', '')
(#2280).It clears all mixins of el.
This PR doesn't touch
removeAttribute('mixin')
becauseanother guy is working on here #2282