-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WebXR gamepads module (fix #4322) #4331
Conversation
squeeze* input events for WebVR and WebXR something aframe needs too? |
on Samsung Odyssey i get this profiles:
|
the strings comes from here https://github.com/immersive-web/webxr-input-profiles/tree/master/packages/registry/profiles |
@dmarcos Yes, it seems like we agreed to name Oculus Touch controllers using the following schema: "oculus-touch" - Rift However, Oculus Browser 7.0 is already ALMOST shipped and this change won't make into it. Hopefully, it will be in 7.1. |
and "oculus-go" - Oculus go |
Also, we are going to support "samsung-gearvr" (at least for some time). |
This is ready to go. FYI, Oculus Browser 7 doesn't yet support the WebXR gamepad module. Interactions are limited to a single button (trigger) until Oculus Browser 7.1 ships. Logic is already wired (tested on Chrome with Rift) and should work with no additional changes. |
I believe this is the last pending PR for 0.9.3 release. We have to do a last QA pass on all devices. Any help testing and filing issues will be appreciated. |
This needs more QA. Chrome Canary and Beta have issues to enter VR today using WebXR and the latest Oculus Runtime and couldn't test thoroughly. |
Sorry, I had missed being pinged. I hope you got this sorted out in the meantime, but for the record the intent is that you should go through the profiles array in order, and use the first profile name for which you find a match in the registry. They are ordered from most-specific to least-specific, with middle entries being reasonably-compatible matches and the last one being a generic fallback with a standard naming scheme describing the available features. |
848ca0b
to
f5dc356
Compare
8dd9399
to
97395e5
Compare
Work in progress with initial support for the gamepads module. @klausw What's the recommended way to identify the controller vendor to load the appropriate model? I see that the gamepad id is not populated and there's an entry in the
XRInputSource .profiles
that saysoculus-touch
for the Oculus Rift headset. Is there a list of vendor strings anywhere? Is the vendor name always guaranteed to be in the first position of the profiles array? Thank you very much.