Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable wakelock on newer iOS #4547

Closed

Conversation

machenmusik
Copy link
Contributor

Description:
Old wakelock code causes intermittent failures on iOS, see immersive-web/webvr-polyfill#354 and #4459.

Changes proposed:
Don't enable wakelock if on newer iOS.

@machenmusik
Copy link
Contributor Author

Note that is it not currently possible to override AFRAME's desired polyfill configuration.

Copy link
Member

@dmarcos dmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any wake lock solution that works on all versions of iOS?

@machenmusik
Copy link
Contributor Author

I don't know, but this was causing sporadic but eventual whiteout AR crashes on WebXR Viewer, and I don't think it works on mobile Safari anymore either.

@dmarcos
Copy link
Member

dmarcos commented Apr 14, 2020

The WebXR Viewer has not been updated since June 2019. Probably better to use Chrome as baseline for WebXR AR features

@machenmusik
Copy link
Contributor Author

Sadly, my understanding is that it's still the only functional AR browser for iOS.
The PR is conditioned on newer iOS since those are where the wakelock is broken.

@dmarcos
Copy link
Member

dmarcos commented Apr 14, 2020

Not sure how much we should accommodate since it doesn’t follow the spec progress. If the project gets picked back up we can look to support.

@dmarcos dmarcos closed this Apr 14, 2020
@machenmusik
Copy link
Contributor Author

My understanding is they are picking it up via webxr branch of firefox-ios. In any event, iOS Safari also fails with the current wakelock, so it may be more important in that regard. Are you sure you want to close?

@machenmusik
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants