Stop the light probe only if this was set up in the first place #5429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elettrotecnica
force-pushed
the
do-not-always-recompute-lights
branch
from
54fe98a
to
9c9cc9d
Compare
|
Indeed, looks good to me. |
dmarcos
reviewed
Jan 12, 2024
src/components/scene/reflection.js
Outdated
| @@ -51,7 +51,9 @@ module.exports.Component = register('reflection', { | |||
| }); | |||
|
|
|||
| this.el.addEventListener('exit-vr', function () { | |||
| self.stopLightProbe(); | |||
| if (self.xrLightProbe) { | |||
There was a problem hiding this comment.
can do one liner
if (self.xrLightProbe) { self.stopLightProbe(); }
There was a problem hiding this comment.
Of course, done
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #5384 and #5384 (comment) in particular
In this proposed change we stop the light probe only when this has been set up in the first place.
All the best