Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toggleable dark/light mode button in hand-tracking example #5504

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

vincentfretin
Copy link
Contributor

Description:

In the button component, in the schema it's "toggable", this is what is used for the dark/light mode button.
The condition in onPressedStarted incorrectly use this.data.togabble instead of this.data.toggable, such the green color wasn't correctly toggled for the button.

Changes proposed:

  • Fix the condition

@dmarcos
Copy link
Member

dmarcos commented Apr 3, 2024

Thanks I think it's misspelled in both original code and fix :) Correct spelling I think would be toggleable. Can we change the schema as well? Thanks

@vincentfretin
Copy link
Contributor Author

Indeed :) I'll look at modifying all occurrences later.

@vincentfretin vincentfretin changed the title Fix toggable dark/light mode button in hand-tracking example Fix toggleable dark/light mode button in hand-tracking example Apr 9, 2024
@vincentfretin
Copy link
Contributor Author

@dmarcos I modified the commit.

@dmarcos
Copy link
Member

dmarcos commented Apr 10, 2024

Thanks so much!

@dmarcos dmarcos merged commit 416ac7d into aframevr:master Apr 10, 2024
1 check passed
@vincentfretin vincentfretin deleted the patch-2 branch April 10, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants