Introduces a registerShader API to be able to add custom shaders to t… #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice. allows the material component to truly be the core component while allowing people to add their own material features like refractions |
dmarcos
force-pushed
the
shaders
branch
6 times, most recently
from
66ee74c
to
9c7c501
Compare
Closed
dmarcos
force-pushed
the
shaders
branch
7 times, most recently
from
e4fa503
to
b7f029e
Compare
| schema: { | ||
| color: { default: '#FFF' , parse: parseColor }, | ||
| fog: { default: true }, | ||
| height: { default: 256 }, |
dmarcos
force-pushed
the
shaders
branch
4 times, most recently
from
ac5d4a2
to
12667d0
Compare
| * | ||
| * @param {object|null} oldData | ||
| */ | ||
| updateTexture: function (data) { |
There was a problem hiding this comment.
can this go outside the prototype?
dmarcos
force-pushed
the
shaders
branch
2 times, most recently
from
943a880
to
58d2a33
Compare
dmarcos
force-pushed
the
shaders
branch
5 times, most recently
from
245c9a7
to
05d7df3
Compare
| Object.keys(propData).forEach(function (propName) { | ||
| if (!schema[propName]) { | ||
| throw new Error('Unknown component property: ' + propName); | ||
| warn('Unknown component property: ' + propName); |
|
r+wc |
…he material interface. A custom shader schema mixes in into the material when applied. Flat and standard register through the same API as the future 3r party shaders.
dmarcos
added a commit
that referenced
this pull request
Mar 3, 2016
Introduces a registerShader API to be able to add custom shaders to t…
|
🌅 😎 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he material interface.
A custom shader schema mixes in into the material when applied.
Flat and standard register through the same API as the future 3rd party shaders.
I still have to cover all the glsl types for the uniforms but we can start reviewing to gain some time