Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callbacks not being called for non-anonymous subclasses #8

Closed
afred opened this issue Nov 15, 2017 · 0 comments
Closed

Callbacks not being called for non-anonymous subclasses #8

afred opened this issue Nov 15, 2017 · 0 comments

Comments

@afred
Copy link
Owner

afred commented Nov 15, 2017

Callbacks are being called for anonymous subclasses generated with test_class_factory method in our tests, but once we try to use non-anonymous classes, any callbacks defined on a subclass are not being called.

Done when: callbacks defined on a subclass are called, when the subclass and it's parent have actual constant names (i.e. are not anonymous).
afred added a commit that referenced this issue Nov 15, 2017
@afred
Fixes non-anonymous callback bug.
d45588b 
Callbacks for named (i.e. non-anonymous) classes were not being called. This was
getting missed in the tests because we are using anonymous classes there.

Also, uses the 'observable' test object in all tests (there was one that wasn't
using it).

Closes #8.

bumps version to 0.2.1
@afred afred mentioned this issue Nov 15, 2017
Merged
@afred afred closed this as completed in #9 Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@afred