Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triangle with racket notation not working in docs or demo #103

Open
kronpano opened this issue Dec 26, 2020 · 7 comments
Open

triangle with racket notation not working in docs or demo #103

kronpano opened this issue Dec 26, 2020 · 7 comments

Comments

@kronpano
Copy link

the notation
Triangle[0,0,0;1,0,0;0.5,0.5,0.5]
doesn't work in the docs (reference on primitives) and also the "normal" demo eisenscript interpreter doesn't accept it.

Only the standard triangle - as in "triangle" - no brackets is accepted.

after12am added a commit that referenced this issue Dec 27, 2020
triangle with racket notation not working in docs or demo #103
after12am added a commit to after12am/eisenscript-editor that referenced this issue Dec 27, 2020
@after12am
Copy link
Owner

after12am commented Dec 27, 2020

@kronpano
Copy link
Author

kronpano commented Jan 2, 2021

It works - yes - but all the numbers need to be positive
A triangle like
triangle[-1,0,1;0,1,0;1,0,1]
is not accepted because of the -1

I usually try to define my triangles around 0,0,0 so rotations are easier to handle.

Also - and yes - that is also the case in StructureSynth - the triangle is only visible from one side. That means you need to define always 2 triangles - one clockwise and one counter clockwise to make sure it can be seen from both sides.
Might be a nice touch to just make it visible from both sides??

@after12am
Copy link
Owner

Ok! I am in travel now. So I will fix it until this weekend.

@after12am
Copy link
Owner

@kronpano

It works - yes - but all the numbers need to be positive
A triangle like
triangle[-1,0,1;0,1,0;1,0,1]
is not accepted because of the -1

fixed it!

https://after12am.github.io/eisenscript-editor/#B/KynKTMxLz0mN1jXUMdAxtAZiHQNrMDsWAA==

Might be a nice touch to just make it visible from both sides??

When using transparent, you can render both sides.

https://after12am.github.io/eisenscript-editor/#B/q1ZIVNCztFSoVSgpykzMS89JjdY11DHQMbQGYh0DazA7FgA=

When not using transparent, you also need to define always 2 triangles.
Because the rendering way is different. Performance is a priority when transparency is not used.

@after12am
Copy link
Owner

When not using transparent, you also need to define always 2 triangles.
Because the rendering way is different. Performance is a priority when transparency is not used.

Fixed it. Now you specify only one side.

https://after12am.github.io/eisenscript-editor/#B/KynKTMxLz0mNNtABQmtDMGmgZ6oDxbEA

@kronpano
Copy link
Author

kronpano commented Jan 11, 2021

Yes, the notation works and it also seems to work in docs but not in the main editor
The example fails as soon as long as box is uncommented with
render.js:266 Cannot read property 'isBufferGeometry' of null

Comment the box out and everything works.
Also the script works if you copy it over to https://after12am.github.io/eisenscript-docs/build/docs/reference-primitives
So I guess it is a deployment problem.

@after12am
Copy link
Owner

Wow! You found it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants