route syntax sugar improvement, eliminate side effects #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking back at the harvester.route (e.g. readonly, immutable... ) methods I now feel that it's making things complex and rigid with not enough benefit.
As part of this change I removed the side-effecting harvester.route functions in favour of pure functions which got added to harvester.routes alongside with the singular route methods (e.g. get, post...)
Rather than
we now declare
and analogue
It's a bit more verbose but composes a lot better, as it allows the resulting route object literals to be passed around and transformed with libs such as lodash and (ramdbajs)[http://ramdajs.com/]