sse adapter approach #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
has a couple of rough edges at this point needs further refactoring
… after hook this change was done as part of AGCMD-43, needs to be investigated
…hey can run with a local or Dockerized Mongodb
# Conflicts: # lib/plugin.js
removed a redundant register of schemas on the plugin namespace
refactored adapter.spec.js a bit as well
| if (!models[hhSchema.type]) { | ||
|
|
||
| // clean up existing models and schemas | ||
| delete mongoose.models[hhSchema.type] | ||
| delete mongoose.modelSchemas[hhSchema.type] | ||
| //delete db.models[hhSchema.type] |
There was a problem hiding this comment.
Not sure why we had to delete them and no longer have to?
There was a problem hiding this comment.
removed the commented code in a new commit
the commit message describes why we no longer need this :
removed commented obsoleted code as we no longer have risk of clashes during tests
nowadays we allocate connections with mongoose.createConnection rather than mongoose.connect
models and schemas are scoped to a specific db object and are cleared out and reinstantiated on every test run
… during tests nowadays we allocate connections with mongoose.createConnection rather than mongoose.connect models and schemas are scoped to a specific db object and are cleared out and reinstantiated on every test run
This was referenced Jan 20, 2016
# Conflicts: # lib/plugin.js # lib/sse.js
# Conflicts: # lib/plugin.js # lib/sse.js
…the app developer to specify the options mongodb adapter and adaptersse : had to go back to an approach using vars the whole adapter connect concept needs to be refactored to properly support an immutable approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Mongodb specific SSE code into an adapter : adapterSSE. This adapter can be configured with options independent from the regular adapter to tweak settings such as maxPoolSize etc
I also took the opportunity to align the connection handling approach between normal db and oplog operations, and clean up the way the plugin integrates this into it's lifecycle