-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up Slice Functor and surrounding infrastructure #347
Conversation
JacquesCarette
commented
Apr 17, 2022
- split off the adjunction into Adjunction.Instance.BaseChange
- make the code less brute force, to hopefully be more revealing as to what is going on
- clean up imports
…de a bit less brute force, and thus hopefully easier to understand.
I've been looking at this file again a bit. We can define It would need some rearrangement, though: because we're using |
Thanks for looking. Think you can push this to the finish line? I'm unlikely to do so for the next 3 months - my term is crazy-busy. |
I can certainly give it a go. By the way, do you or @HuStmpHrrr know where the names of |
* Move forgetful-free adjunction to its own file * Move base change functors to their own file * Define base change functors indirectly * Define base change adjunction indirectly
I think |
Sandro's answer is very much accurate. |
I want to look closer at I also want to rename |
So I can't officially review, since strictly speaking, this PR is under my name - but @Taneb can review it. I'm actually happy with the PR as it is. The extra modifications above can be done in a subsequent PR. |