Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add strict initial objects #423

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Add strict initial objects #423

merged 4 commits into from
Jul 2, 2024

Conversation

4e554c4c
Copy link
Contributor

This commit add strict initial object, and proves that any initial object in a CCC is strict. There is also a refactoring of the empty diagram.

@4e554c4c
Add strict initial objects
39dbf92 
This commit add strict initial object, and proves that any initial
object in a CCC is strict. There is also a refactoring of the empty
diagram.
@4e554c4c 4e554c4c mentioned this pull request Jun 25, 2024
Merged
@4e554c4c 4e554c4c marked this pull request as draft June 25, 2024 14:11
@4e554c4c 4e554c4c marked this pull request as ready for review June 25, 2024 14:44
@4e554c4c
rename Empty to Zero
0d2e0cb 
This commit also contains a slight refactor of `EmptySet`. There is no
need for this type to depend on the unit.
@4e554c4c 4e554c4c requested a review from Taneb June 30, 2024 18:32
JacquesCarette
JacquesCarette requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful refactoring! One minor thing to fix before I merge.

src/Categories/Object/StrictInitial.agda Outdated Show resolved Hide resolved
@JacquesCarette
Copy link
Collaborator

On the question

I wonder why everything was using liftC (Discrete 0) then

This is because Data.Empty.Polymorphic did not yet exist when this was created. I contributed those because of this lack, but never had the chance to come back to agda-categories to refactor!

@JacquesCarette JacquesCarette merged commit 26b90e3 into agda:master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesCarette JacquesCarette JacquesCarette approved these changes

@Taneb Taneb Awaiting requested review from Taneb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4e554c4c @JacquesCarette @Taneb