-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of empty code blocks in HTML/MD backend #6880
Conversation
Looks legit! Is there any chance where you'll be having highlighting in a background text? |
A priori no, since the literate parsers can be seen to never output a |
fffccb2
to
7ba40bc
Compare
CI fails |
Yeah, I don't think it's due to this PR. |
@Mergifyio rebase |
Instead of assuming the runs of tokens alternate between background and code, look at each run to determine what kind of tokens it contains, just like for org mode. Fixes #6873
✅ Branch has been successfully rebased |
7ba40bc
to
e6a9b93
Compare
@wenkokke : Would you have the capacity now to test this PR on plfa? |
Unfortunately, it seems PLFA doesn't compile with Agda 2.6.4, so it's difficult to test this PR:
|
@wenkokke : This version of lists is now only allowed with flag data List′ : Set → Set where
[]′ : ∀ {A : Set} → List′ A
_∷′_ : ∀ {A : Set} → A → List′ A → List′ A Lines 227 to 242 in 338efc9
|
I believe this doesn't break PLFA. |
Thanks, everyone! |
Instead of assuming the runs of tokens alternate between background and code, look at each run to determine what kind of tokens it contains, just like for org mode.
Fixes #6873
cc @ice1000 since you authored the original
mkMd
.