Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graded commutativity of cup product #938

Merged
merged 20 commits into from
Oct 7, 2022

Conversation

aljungstrom
Copy link
Contributor

This PR contains graded commutativity for the various versions of the cup product in the library. The main result (or, at least, the most general one) is the final theorem in Homotopy.EilenbergMacLane.GradedCommTensor. The proof itself is (beautiful in theory but in practice) a massive mess of transports and congs. It should be read by no one.

This means some ad hoc solutions in Cohomology/Rings can be removed, but I'll leave this for a future PR.

Copy link
Collaborator

@mortberg mortberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various minor suggestions.

Does it make sense to instantiate this more general result to derive the result for Z-cohomology?

Cubical/Cohomology/EilenbergMacLane/CupProduct.agda Outdated Show resolved Hide resolved
Cubical/Data/Nat/Properties.agda Show resolved Hide resolved
Cubical/Data/Sigma/Properties.agda Show resolved Hide resolved
Cubical/Homotopy/EilenbergMacLane/CupProduct.agda Outdated Show resolved Hide resolved
Cubical/Homotopy/EilenbergMacLane/GradedCommTensor.agda Outdated Show resolved Hide resolved
Cubical/Homotopy/EilenbergMacLane/GradedCommTensor.agda Outdated Show resolved Hide resolved
@aljungstrom
Copy link
Contributor Author

@mortberg should be done now

@mortberg mortberg merged commit 6e67e4a into agda:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants