The Structure Sheaf #941
Merged
The Structure Sheaf #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
requested changes
Oct 12, 2022
| open CommRingStr | ||
| private | ||
| A = fst Aφ | ||
| froToCommRingPath : CommAlgebra→CommRing (toCommAlg Aφ) ≡ fst Aφ |
There was a problem hiding this comment.
Not a great name and also in another PR?
There was a problem hiding this comment.
Yeah something similar is done in #931
There was a problem hiding this comment.
Did you decide what to do about this? Maybe just a better name is sufficient?
There was a problem hiding this comment.
I went with CommAlgebra→CommRing≡
There was a problem hiding this comment.
Maybe @MatthiasHu can fix his PR once this is merged and figure out what broke in his proposal
|
OK, hope the checks pass and the PR is ready to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we construct the structure sheaf on the Zariski lattice of a commutative ring and prove the sheaf property.
This builds on #929 but diverges a bit, so it might be best to close that PR.
The older and weaker "pullback" version can probably be removed now.