Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unhandled Error during connection. #98

Closed
ArtemHoruzhenko opened this issue Jan 3, 2023 · 2 comments
Closed

Unhandled Error during connection. #98

ArtemHoruzhenko opened this issue Jan 3, 2023 · 2 comments
Labels
in review
Milestone
5.5

Comments

@ArtemHoruzhenko
Copy link

I could see rejection for server
image
Also there is rejection for client
image

But there is no rejection on main promise in the createTunnel function
image

Basically we will see
image
if invalid options provided which makes this lib useless for prod

Also, not sure what is "reject" on line 36?
image
ArtemHoruzhenko pushed a commit to ArtemHoruzhenko/tunnel-ssh that referenced this issue Jan 3, 2023
fix agebrock#98
bc3e2af
@agebrock
Copy link
Owner

Thx for the feedback.

we will look into it on the weekend .

@agebrock agebrock added this to the 5.5 milestone Jan 16, 2023
agebrock added a commit that referenced this issue Jan 23, 2023
@agebrock
improved error handling [#98]
28fd601
@agebrock
Copy link
Owner

Hi there, we improved the error handling in 5.0.5 just now.
Let me know if your issues are solved.

Kind Regards
Chris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in review
Projects
None yet
Milestone
5.5
Development

No branches or pull requests
2 participants
@agebrock @ArtemHoruzhenko