Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default limit of 200 jobs #15

Merged
merged 2 commits into from
Apr 4, 2016
Merged

Default limit of 200 jobs #15

merged 2 commits into from
Apr 4, 2016

Conversation

joeframbach
Copy link
Member

No description provided.

@joeframbach joeframbach mentioned this pull request Mar 30, 2016
Closed
vziukas
vziukas reviewed Mar 30, 2016
View reviewed changes
lib/agendash.js
@@ -163,6 +163,8 @@ module.exports = function (agenda, options) {
var postMatch = {}
if (state) postMatch[state] = true

var limit = 200 // todo UI param
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add skip as well, so that can be user for pagination later. Ex:

skip 0 limit 200 = 1st page
skip 200 limit 200 = 2nd page
skip 400 limit 200 = 3rd page.

We just need to wire from UI controls.

@joeframbach joeframbach merged commit fb65012 into master Apr 4, 2016
@joeframbach joeframbach deleted the limit-200 branch April 4, 2016 18:57
simison pushed a commit that referenced this pull request Jan 16, 2021
@santiq
Merge pull request #16 from Software-On-The-Road/improve-metadata-field
9ca9932 
Add prism.js to improve metadata syntax highlight
Fixes #14 
Fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeframbach @vziukas