Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bit of care taking on the code itself. #13

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

A bit of care taking on the code itself. #13

wants to merge 6 commits into from

Commits on Aug 18, 2016

  1. Minor PHPDoc comment fixes. 

    Signed-off-by: George Petsagourakis <petsagouris@gmail.com>
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    a56247a View commit details
    Browse the repository at this point in the history

  2. Code restructuring and one single bug fix. 

    Mostly restructuring the logic statements for clarity and making code logic more shallow.
The bug fix is about the Collection.php file around @@180 that had `$this->getCollectionNames()` instead of `$this->database->getCollectionNames()`

Signed-off-by: George Petsagourakis <petsagouris@gmail.com>
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    b90c334 View commit details
    Browse the repository at this point in the history

  3. Replacing the array_key_intersect function with the builtin `array_… 

    …intersect_key` function.

Signed-off-by: George Petsagourakis <petsagouris@gmail.com>
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    64f610d View commit details
    Browse the repository at this point in the history

  4. Replacing functionality with builtin function array_column. 

    Signed-off-by: George Petsagourakis <petsagouris@gmail.com>
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    5eef537 View commit details
    Browse the repository at this point in the history

  5. Removing the $r approach. 

    Introducing throwing `RuntimeException` for `json_decode` errors.

Signed-off-by: George Petsagourakis <petsagouris@gmail.com>
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    25b164a View commit details
    Browse the repository at this point in the history

  6. Adding couple of entries to the .gitignore for cleanliness and removi… 

    …ng composer.lock.

The composer .lock is recommended that it is not committed as per Composer guidelines. (see https://getcomposer.org/doc/02-libraries.md#lock-file).

Also trying to make the conflict in Collection.php go away.
    @petsagouris
    petsagouris committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    8025e16 View commit details
    Browse the repository at this point in the history